GitLab

Html2Pdf.php: Fake the current 'user-agent' and add it as '--custom-header ...' AND '--custom-header-propagation' option to the wkhtmltopdf call. Without, T3 will deny FE Group access. The --custom-header-propagation seems to be necessary.

Manual.rst: describe new urlParam parameter `_sip`
Html2Pdf.php: optional SIP encoding

Html2Pdf.php: Add SIP support wkhtmltopdf URLs. Move cookies for wkhtmltopdf from commandline arguments to filebased.

Implemented defaultEscapeType. configurable via config.qfq.ini (global) and per Form.
Implemented max GET parameter lenght. Default: 50. BTW: in phpunit test there have been a parameter 'file' which exceeds the limit of 32.

Config.qfq: Skip empty variable names - happens in phpunit tests. Read new `systemEscapeTypeDefault`.
Constants.php: renamed  TOKEN_LDAP_ESCAPE_* to TOKEN_ESCAPE_LDAP_*. Add TOKEN_ESCAPE_MYSQL, TOKEN_ESCAPE_NONE
Database.php: Set charset to real_escape_string() functions properly. Proxy for mysqli::real_escape_string()
Evaluate.php: Respect global escapeTypeDefault. Implement
formEditor.sql: add column `escapeTypeDefault`. Add FormElement 'escapeTypeDefault'.

Config.php: Defaults are now set in Config.php, not in Store.php anymore. New function setDefaults(), checkForAttack().

Play: ALTER TABLE  `FormElement` ADD  `encode` ENUM(  'none',  'specialchar' ) NOT NULL DEFAULT  'specialchar' AFTER  `subrecordOption` ;
Play: formEditor.sql

Attention: FEs with text=editor needs actions - the default of 'specialchar' prohibits saving of HTML tags.

FillStoreForm.php: Submitted values will be specialchars() before copying to STORE_FORM.
AbstractBuildForm.php: Counterpart of FillStoreForm.php - will htmlspecialchars_decode() values read from database. Replace 'checkType' and 'checkPattern' with CONSTANTS.
formEditor.sql: Added new column in FormElement. Add new FormElement 'encode' in FormElement-Editor. Add column 'encode' to all FormElement records.

Handling of filenames in Zip's optimized. Spoken filename (no cryptic tempnames anymore). Correct filename extension, based on the mimetype.

Manual.rst: updated doc for columns  _pPdf,_zZip, _fFile. Remove doc for '_dDownload'.
Download.php: new function targetFilenameExtension(). Replace cryptic temporary filenames against file-1, ...
Link.php: reorder param array, to make TOKEN_DOWNLOAD position independet
Report.php: Implemented _pPdf,_zZip, _fFile.

Link.php: If there is no output filename defined, the default is now computed in Download.php, not in Link.php as before.
Download.php: Extract filename extension from mimetype, compare it with output filename, if it does not match, append the computed extension. This forces the filemanager to open the correct application after download.

* Recode the '_link' notation for download
* Add 'ZIP' as export format
* Add 'parameter' to wkhtmltopdf
* Implemented 'SYSTEM_STORE / SYSTEM_DOWNLOAD_POPUP' for detecting if there are download links on the page. This eleminates passing parameters through dozens of functions.
* Report/Columntype '_dDownload' broken!
Coding.md: described `download` from a coding point of view.
Manual.rst: Update '_link' to latest notation of 'download'.
download.php: implemented catching of 'Undefined index'. Added further exceptions.
Download.php: Added cache=off for downloading. Rename getFile() to getElement(). Make getElement() more generic. Add zipFiles(). Implement 'downloadMode' in doElements().
Html2Pdf.php: recode to new download notation. Parameter to wkhtmltopdf implemented.
Link.php: New TOKEN_* and NAME_DOWNLOAD_*, NAME_FILE. Move TOKEN_* to Constants.php. Will be used in Download.php too. Implemented 'SYSTEM_STORE / SYSTEM_DOWNLOAD_POPUP'. Implemented BASE64 encoding of multiple 'U' and 'u'.
Report.php: Implemented 'SYSTEM_STORE / SYSTEM_DOWNLOAD_POPUP'.
Sip.php: implement debugSip() to show Sip. New: base64 encoded parameter will be shown in clear.
Store.php: some functions missed keyword 'static'. getVar() and getStore automatically decode base64 parameter.
QuickFormQuery.php: Implemented 'SYSTEM_STORE / SYSTEM_DOWNLOAD_POPUP'.

Implemented spinning wheel (hourglass) displayed during rendering and downloading PDF.
Link.php, Report.php: New $vars[NAME_EXTRA_CONTENT_WRAP] which holds a '<button>' definition with necesary 'data-*' attributes. The Modal Dialog needs a uniq html id (derived from ttContentUid). That one is returned to Report() if there is at least one download element.

Implemented download.php to offer SIP protected downloads for single files (any filetype) as well as concatenated PDF files and converted HTML pages.
download.php: API Interface
DownloadException.php: New exception class for downloads - might be extended for better error handling.
OnArray.php: new function getArrayItemKeyNameStartWith() to filter for specific elements in an array. New function arrayEscapeshellarg() to escape args
Download.php: Main class.
Link.php, Report.php: implemented new link type 'd' (=download)

Manual.rst: Prefetch doc enhanced.
Ldap.php: replacement of '?' in LDAP search not processed with MODE_LDAP_PREFETCH - fixed. FE_TYPEAHEAD_LDAP_KEY_PRINTF renamed to FE_TYPEAHEAD_LDAP_ID_PRINTF
AbstractBuildForm.php: copy 'FE_TYPEAHEAD_LDAP_ID_PRINTF' to SIP seems never be done - fixed

#3552 / typeAheadLdapSearchPerToken - webpass kann nicht gleichzeitig nach Vornamen und Nachnamen suchen
Neuen Modus 'typeAheadLdapSearchPerToken' implementiert.
Manual.rst: neues Feature dokumentiert.
Ldap.php: Neue Funktion 'explodePermutSearch()'.

During expanding of templateGroups, existing FE with no meaning for save (like note, subrecord, ...) has been created, filled with empty values and saved. Fixed for FEs with type 'subrecord' and 'note' - needs more investigation to check for further sideeffects.

Action elements, assigned to a container which are not a templategroup, threw an exception. In general, it makes no sense (at the time of writing this) to assign an action element to a pill or fieldset, but it should not throw an exception. Fixed - just ignore such assignment.

Implemented.

Exception: rewrote getting T3 parameter without using Store(). Always report pages.uid, tt_content.uid.
 T3Info.php: new class
 Sip.php: penalty time for broken sip.
 Store.php: moved T3 code to T3Info.php

#3502 / TemplateGroups: Checkboxen werden beim ersten Speichern (insert) nicht geschrieben - ein anschliessendes Update ist ok
Das Problem tritt nur auf bei MultiCheckboxen. Neu werden im Store  STORE_ADDITIONAL_FORM_ELEMENTS (ist bereits frueher, extra fuer Checkboxen, eingefuehrt worden) fuer alle TemplateGroup FEs (type=checkbox) die Fake Elemente angelegt. Dazu wird neu NAME_TG_COPIES in dem FEs gefuellt mit dem 'TG max copies'-Wert.

Manual.rst: update doc how to insert/update/delete non primary templateGroup records.
FormAction.php: removed $templateGroupIndex - solved implicit by defining a LIMIT on 'slaveId' . Implemented '%D' (one below %d). Implemented FE_SQL_HONOR_FORM_ELEMENTS - reduces unecassary SQL queries.
HelperFormElement.php: moved function 'explodeTemplateGroupElements()' to 'QuickFormQuery.php'
Database.php: remove call to explodeTemplateGroupElements() - not necessary at that place.
QuickFormQuery.php: fill STORE_RECORD during Formload - to read templateGroup records very early. Local copy of `getNativeFormElements()`, new `explodeTemplateGroupElements()`

Mode: typeAheadPedantic
TypeAhead.php: Implemented new parameter  TYPEAHEAD_API_PREFETCH.
Ldap.php: add new mode MODE_LDAP_PREFETCH
AbstractBuildForm.php: If FE_TYPEAHEAD_PEDANTIC is specified, add attribute DATA_TYPEAHEAD_PEDANTIC,'true'

Implementation started - code is broken

Neu: Form.parameter.saveButtonActive - if this attribute is set, the save button will be enabled directly on form load.
Manual.rst: update doc
BuildFormBootstrap.php:: Add new attribute to 'form'-tag

Implemented the option to make a form `readonly`. this can be done statically or dynamically via variable (e.g. SIP).
QuickFormQuery.php, AbstractBuildForm.php: Force 'readonly' by overwriting FormElement individual 'mode' setting.
BuildFormBootstrap.php: Introduced new variable F_SHOW_BUTTON.

#3447 / Icons das man im FrontEnd direkt das gewaehlte FormElement im Formulareditor bearbeiten kann.
AbstractBuildForm.php: Add checkbox left to the 'EditForm'-Button to toogle the 'FormElemnt'-Icons -as the regular 'Form Edit'-Pencil, the 'FormElement Checkbox' is only displayed if the user is logged in BE.
BuildFormBootstrap.php: new function 'buildEditFormElementCheckbos()'

Manual.rst: Updated doc for a) config.qfq.ini: LDAP_1_RDN, LDAP_1_PASSWORD, b) Form.parameter|FormElement.parameter: ldapUseBindCredentials
ErrorHandler.php: removed details - the end user should not too many details.
FormAction.php, Ldap.php, QuickFormQuery.php: implement 'ldapUseBindCredentials'
Ldap.php: set_error_handler() to catch ldap_bind() problems. Always set LDAP_OPT_PROTOCOL_VERSION=3 - this might cause problems with som LDAP Servers - we will see.

#3447 / Icons das man im FrontEnd direkt das gewaehlte FormElement im Formulareditor bearbeiten kann
AbstractBuildForm.php, BuildFormBootstrap.php, BuildFormTable.php: Function createFormEditorUrl extended to accept parameter, to make it more generic (best would be to use the 'Link' class). Build the FormElement Edit symbol as together with debug stack symbols

The new implementation creates empty fake instances of all copies of templateGroup FormElements. Those are empty. Before save, the submitted form values will be expanded with the empty fake templateGroup FormElements and such empty values will be saved.
FormAction.php: Rename constant SQL_FORM_ELEMENT_TEMPLATE_GROUP to SQL_FORM_ELEMENT_TEMPLATE_GROUP_FE_ID - to be more precise.
HelperFormElement.php, Database.php: new function explodeTemplateGroupElements()

#3431 / typeAheadSql: columnname 'key' is a reserverd SQL statement - replace by 'id'. Additional the parametername 'typeAheadLdapKeyPrintf' renamed to 'typeAheadLdapIdPrintf'.
typeAhead.php: fixed typo.
TypeAhead.php: introduced new mapping from 'id' (SQL) to 'key' (API).
AbstractBuildForm.php: Constant renamed.
Database.php: update function makeArrayDict() to reflect name mapping.

AbstractBuildForm.php: Saving 'extra' FE in STORE_SIP has been done with inappropiate FE_NAME. Correct is the pure FE_NAME, without any extension like recordId. Unessary and broken decoding removed.

HelpFormElement.php: Introduced new constants HTML_DELIMITER_NAME, HTML_DELIMITER_ID
AbstractBuildForm.php: Saving 'extra' FE in STORE_SIP has been done with inappropiate FE_NAME. Correct is the pure FE_NAME, without any extension like recordId. Unessary and broken decoding removed.

Fix #3420 / Quicklink 'editform' on form: directs to the current T3 page which might be insufficient
AbstractBuildForm.php, Store.php: Introduce new config.qfq.ini setting 'EDIT_FORM_PAGE'

Manual.rst: Update Doc for new option 'bsColumns'
Config.php: Copy new element from general config.
Store.php: set default for 'bsColumns'.
QuickFormQuery.php: wrap whole form in 'col-md-XX'

Ldap.php: Added checks for missing LDAP..._SEARCH. Do not throw an error if there is an empty result. HTML Entitites for typeahead will be escaped on client side.

OnArray.php: new function 'arrayValueReplace()'.
AbstractBuildForm.php: Load foreign values in templatGroups.

Typeahead (#3369): Parameternames has changed, configuration is possible on the Form and on the FormElement.
typeahead.php: if there is an exception, the message body is sent as regular 'content' for the dropdownbox. At the moment this is the only way to transmit any error messages.
Ldap.php: missing FE_TYPEAHEAD_LDAP_KEY_PRINTF, FE_TYPEAHEAD_LDAP_VALUE_PRINTF will be substituted by the other. If both missing, an exception is thrown.

BuildFormBootstrap.php: wrapping of optional 'submitButtonText' now done with the configured form wrap setup
qfq-bs.css.less: dislay characterCount inside of input/textarea element.