Merge branch 'B3529-no-double-urldecode-for-GET-parameters' into 'master'

B3529 - No double urldecode() of GET parameters - refs #3529, closes #3529

See merge request !104

extension/qfq/qfq/helper/Sanitize.php

@@ -252,33 +252,7 @@ class Sanitize {
         return $item;
     }
 
-    /**
-     * urlencode() any input and decode again. This normalizes all characters and guarantees that there are no more
-     * urlencoded characters.
-     *
-     * @param array|string $item
-     *
-     * @return array|string
-     * @throws CodeException
-     */
-    public static function urlDecodeArr($item) {
-
-        if (is_array($item)) {
-            foreach ($item as $key => $value) {
-                $value = self::urlDecodeArr($value);
-                $item[$key] = $value;
-            }
-        } else {
-            if (is_string($item)) {
-                $item = urldecode($item);
-            } elseif (!is_numeric($item)) {
-                throw new qfq\CodeException ("Expect type 'string / numeric / array' - but there is something else.", ERROR_UNEXPECTED_TYPE);
-            }
-        }
-
-        return $item;
-
-    }
+ 
 
     /**
      * Check a given $_GET[$key] is digit.

extension/qfq/qfq/store/Client.php

@@ -35,7 +35,7 @@ class Client {
         Sanitize::digitCheckAndCleanGet(CLIENT_PAGE_LANGUAGE);
 
         if (isset($_GET)) {
-            $get = Sanitize::urlDecodeArr($_GET);
+            $get = $_GET; // do not use urldecode() - http://php.net/manual/de/function.urldecode.php#refsect1-function.urldecode-notes
         }
 
         if (isset($_POST)) {