Config.php: remove default definition to fire SQL periodId

phpUnitTests: fixed some defintions of string/int

extension/qfq/qfq/Constants.php

@@ -461,7 +461,7 @@ const SYSTEM_RECORD_LOCK_TIMEOUT_SECONDS_DEFAULT = 900; // 15 mins
 
 // Deprecated, replaced by SYSTEM_FILL_STORE_SYSTEM_BY_SQ
 const SYSTEM_VAR_ADD_BY_SQL = 'VAR_ADD_BY_SQL';
-const SYSTEM_VAR_ADD_BY_SQL_DEFAULT = 'SELECT id AS periodId FROM Period WHERE start<=NOW() ORDER BY start DESC LIMIT 1';
+//const SYSTEM_VAR_ADD_BY_SQL_DEFAULT = 'SELECT id AS periodId FROM Period WHERE start<=NOW() ORDER BY start DESC LIMIT 1';
 
 const SYSTEM_FILL_STORE_SYSTEM_BY_SQL = 'FILL_STORE_SYSTEM_BY_SQL';
 const SYSTEM_FILL_STORE_SYSTEM_ERROR_MSG = 'FILL_STORE_SYSTEM_ERROR_MSG';

extension/qfq/qfq/store/Config.php

@@ -207,7 +207,7 @@ class Config {
 
         Support::setIfNotSet($config, DOCUMENTATION_QFQ, DOCUMENTATION_QFQ_URL);
 
-        Support::setIfNotSet($config, SYSTEM_FILL_STORE_SYSTEM_BY_SQL, SYSTEM_VAR_ADD_BY_SQL_DEFAULT);
+//        Support::setIfNotSet($config, SYSTEM_FILL_STORE_SYSTEM_BY_SQL, SYSTEM_VAR_ADD_BY_SQL_DEFAULT);
 
         return $config;
     }

extension/qfq/tests/phpunit/StoreTest.php

@@ -252,8 +252,8 @@ EOT;
             SYSTEM_DB_INIT => 'set names utf8',
             SYSTEM_SQL_LOG_MODE => 'modify',
 
-            SYSTEM_DB_INDEX_DATA => 1,
-            SYSTEM_DB_INDEX_QFQ => 1,
+            SYSTEM_DB_INDEX_DATA => '1',
+            SYSTEM_DB_INDEX_QFQ => '1',
 
             SYSTEM_DATE_FORMAT => 'yyyy-mm-dd',
             SYSTEM_SHOW_DEBUG_INFO => SYSTEM_SHOW_DEBUG_INFO_NO,
@@ -287,9 +287,9 @@ EOT;
             F_BUTTON_ON_CHANGE_CLASS => 'btn-info alert-info',
             SYSTEM_EDIT_FORM_PAGE => 'form',
             SYSTEM_SECURITY_VARS_HONEYPOT => 'email,username,password',
-            SYSTEM_SECURITY_ATTACK_DELAY => '5',
+            SYSTEM_SECURITY_ATTACK_DELAY => 5,
             SYSTEM_SECURITY_SHOW_MESSAGE => '0',
-            SYSTEM_SECURITY_GET_MAX_LENGTH => '50',
+            SYSTEM_SECURITY_GET_MAX_LENGTH => 50,
             SYSTEM_ESCAPE_TYPE_DEFAULT => 'm',
             SYSTEM_GFX_EXTRA_BUTTON_INFO_INLINE => '<span class="glyphicon glyphicon-info-sign" aria-hidden="true"></span>',
             SYSTEM_GFX_EXTRA_BUTTON_INFO_BELOW => '<span class="glyphicon glyphicon-info-sign text-info" aria-hidden="true"></span>',
@@ -299,8 +299,6 @@ EOT;
             SYSTEM_RECORD_LOCK_TIMEOUT_SECONDS => SYSTEM_RECORD_LOCK_TIMEOUT_SECONDS_DEFAULT,
 
             DOCUMENTATION_QFQ => DOCUMENTATION_QFQ_URL,
-            SYSTEM_VAR_ADD_BY_SQL => 'SELECT id AS periodId FROM Period WHERE start<=NOW() ORDER BY start DESC LIMIT 1',
-
         ];
 
         $fileName = $this->createFile($body);