From 5b0416b12931b5ed1f0b6ba2d9d9b3909ea5dd9e Mon Sep 17 00:00:00 2001
From: Carsten Rose <carsten.rose@math.uzh.ch>
Date: Mon, 18 Apr 2016 19:11:03 +0200
Subject: [PATCH] AbstractBuildForm.php: various form elements missed the
'title' attribute (used as tooltip). Fixed. 'Radio', 'Multi Checkbox' and
'Multi Select' only have one tooltip for all elements. This might be improved
later.
---
extension/qfq/qfq/AbstractBuildForm.php | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/extension/qfq/qfq/AbstractBuildForm.php b/extension/qfq/qfq/AbstractBuildForm.php
index 0806b265a..88910c5c8 100644
--- a/extension/qfq/qfq/AbstractBuildForm.php
+++ b/extension/qfq/qfq/AbstractBuildForm.php
@@ -899,6 +899,7 @@ abstract class AbstractBuildForm {
$attribute .= Support::doAttribute('name', $htmlFormElementId);
$attribute .= Support::doAttribute('value', $formElement['checked'], false);
+ $attribute .= Support::doAttribute('title', $formElement['tooltip']);
$attribute .= Support::doAttribute('data-load', ($formElement['dynamicUpdate'] === 'yes') ? 'data-load' : '');
if ($formElement['checked'] === $value) {
@@ -1037,6 +1038,8 @@ abstract class AbstractBuildForm {
}
$attribute .= Support::doAttribute('value', $itemKey[$ii]);
+ $attribute .= Support::doAttribute('title', $formElement['tooltip']);
+
if ($itemKey[$ii] === $value) {
$attribute .= Support::doAttribute('checked', 'checked');
}
@@ -1079,6 +1082,7 @@ abstract class AbstractBuildForm {
$attribute = $this->getAttributeMode($formElement);
$attribute .= Support::doAttribute('name', $htmlFormElementId);
+ $attribute .= Support::doAttribute('title', $formElement['tooltip']);
$attribute .= $this->getAttributeList($formElement, ['autofocus']);
$attribute .= Support::doAttribute('data-load', ($formElement['dynamicUpdate'] === 'yes') ? 'data-load' : '');
@@ -1438,6 +1442,7 @@ abstract class AbstractBuildForm {
$attribute = $this->getAttributeMode($formElement);
$attribute .= Support::doAttribute('type', 'file');
+ $attribute .= Support::doAttribute('title', $formElement['tooltip']);
$attribute .= Support::doAttribute('name', $htmlFormElementId);
$attribute .= $this->getAttributeList($formElement, ['autofocus', 'accept']);
$attribute .= Support::doAttribute('data-load', ($formElement['dynamicUpdate'] === 'yes') ? 'data-load' : '');
--
GitLab