From 13453f8164d3e56b2966d873b5df1da8cf7426b6 Mon Sep 17 00:00:00 2001 From: Carsten Rose <carsten.rose@math.uzh.ch> Date: Wed, 14 Mar 2018 23:24:49 +0100 Subject: [PATCH] Bug #5652 / TypeAheadSql: destroyed SQL statement. Fixed broken comparison and missing init of $sqlTest. --- extension/qfq/qfq/AbstractBuildForm.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/extension/qfq/qfq/AbstractBuildForm.php b/extension/qfq/qfq/AbstractBuildForm.php index acd4174fc..7d527d2e4 100644 --- a/extension/qfq/qfq/AbstractBuildForm.php +++ b/extension/qfq/qfq/AbstractBuildForm.php @@ -1265,14 +1265,16 @@ abstract class AbstractBuildForm { $sql = trim($sql); - if ($sql[0] = '[') { + if ($sql[0] == '[') { // Remove optional existing dbIndex token. $pos = strpos($sql, ']'); $sqlTest = substr($sql, $pos + 1); + } else { + $sqlTest = $sql; } if (false === stristr(substr($sqlTest, 0, 7), 'SELECT ')) { - throw new UserFormException("Expect a SELECT statement in " . FE_TYPEAHEAD_SQL . " - got: " . $sql, ERROR_BROKEN_PARAMETER); + throw new UserFormException("Expect a SELECT statement in " . FE_TYPEAHEAD_SQL . " - got: " . $sqlTest, ERROR_BROKEN_PARAMETER); } if (false === stristr($sql, ' LIMIT ')) { -- GitLab